-
-
Notifications
You must be signed in to change notification settings - Fork 187
fix #109 and #137, hopefully #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Definitely better than the status quo. The the double scroll bar in this PR doesn't look great though. I think if it were possible to hide the scrollbar, but still allow the section to be scrollable it might be preferable in this instance
This one looks fixed. I see the scrollbar on the right of the screen still - not the left. But I no longer get the jumping effect |
Isn't hiding scrollbars on platforms where they'd normally render considered bad form? Most of the time it won't appear, since the list won't be tall enough |
Yeah, but so is having multiple scrollbars on a page. I wouldn't hide them as a matter of practice, but it might be the lesser of two evils in this case. I'd be curious for more opinions on it though |
The double scrollbar looks awful, I'm with Ben here - better to hide it in this case. In fact it is already implemented this way on the current site (see https://svelte.dev/docs/accessibility-warnings for example), so I'm not 100% sure when this regressed on the omnisite. |
discovered |
This attempts to fix #109, by making the sidebar scrollable, and #137 by positioning the sidebar relative to the left of the screen rather than the right.
@benmccann @dummdidumm can you try this out and see how it looks?
I don't think we can avoid having duplicate scroll bars on operating systems that still, in 2024, insist on rendering them for some reason. This PR tries to make it acceptable by shrinking the right sidebar such that a) they don't butt up against each other and b) it's very clear which sidebar relates to what content. But I have no way to judge how it looks.